Polygon fixes and Brep from step for Rhino #1424
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
=======================================
Coverage 61.77% 61.78%
=======================================
Files 207 207
Lines 22300 22311 +11
=======================================
+ Hits 13776 13785 +9
- Misses 8524 8526 +2 ☔ View full report in Codecov by Sentry. |
| obj = compas_rhino.objects.find_object(guid) | ||
| geometry = obj.Geometry.Duplicate() | ||
| compas_rhino.objects.delete_object(guid) | ||
| return cls.from_native(geometry) |
There was a problem hiding this comment.
is geometry guaranteed to be Brep every time?
There was a problem hiding this comment.
perhaps not but then it will just throw an error, which is probably also what is supposed to happen
| :class:`compas_rhino.geometry.RhinoBrep` | ||
|
|
||
| """ | ||
| rs.Command('_-Import "' + filepath + '" _Enter', False) |
There was a problem hiding this comment.
this would import any kind of file, right?
just thinking out loud, could be nice to maybe do this in the future using Rhino.FileIO.FileStp
although that one also draws directly to a RhinoDoc, so not very clean. a bit more explicit though.
Anyways, maybe this is good enough for now
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.