Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for some of the major classes #423

Closed

Conversation

yck011522
Copy link
Contributor

Addresses #416

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@yck011522 yck011522 added the no changelog Disables changelog checker label May 10, 2024
@yck011522 yck011522 self-assigned this May 10, 2024
@yck011522
Copy link
Contributor Author

This is partly address #416

@yck011522
Copy link
Contributor Author

Waiting for #422 to change also the type hints for plan_cartesian_motion.
Waiting for #424 to change the type hints in the backend features.

@yck011522 yck011522 changed the base branch from main to feature_plan_c_motion_uses_waypoints June 7, 2024 03:17
@jf---
Copy link

jf--- commented Jun 7, 2024

@yck011522 a terrific contribution

@yck011522
Copy link
Contributor Author

blocked by #422

@yck011522 yck011522 deleted the branch feature/plan_cartesian_uses_waypoints June 13, 2024 06:31
@yck011522 yck011522 closed this Jun 13, 2024
@yck011522
Copy link
Contributor Author

Okay everyone I'm messing everything up with renaming a branch. I hope there isn't any opened review here. I'll make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Disables changelog checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants