Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Planner call magic, using multi-inherence instead. #433

Merged
merged 14 commits into from
Jun 14, 2024

Conversation

yck011522
Copy link
Contributor

A continuation of #424 after I messed things up.

Base automatically changed from feature_plan_c_motion_uses_waypoints to main June 14, 2024 08:20
CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines -36 to -38
@forward_docstring(MoveItForwardKinematics)
def forward_kinematics(self, *args, **kwargs):
return MoveItForwardKinematics(self.client)(*args, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

def plan_cartesian_motion(self, *args, **kwargs):
return AnalyticalPlanCartesianMotion(self)(*args, **kwargs)
def __init__(self, connection_type="gui", verbose=False):
PyBulletClient.__init__(self, connection_type=connection_type, verbose=verbose)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct to explicitly use the super class instead of super?

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yck011522 yck011522 merged commit 74dfc5a into main Jun 14, 2024
13 checks passed
@yck011522 yck011522 deleted the remove_planner_call_magic branch June 14, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants