Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Te cdk replatform #1927

Open
wants to merge 64 commits into
base: edge
Choose a base branch
from
Open

Te cdk replatform #1927

wants to merge 64 commits into from

Conversation

tevko
Copy link
Collaborator

@tevko tevko commented Feb 14, 2025 •
edited
Loading

image

@jucor
Copy link
Contributor

jucor commented Feb 15, 2025

@tevko I've started porting to CDK my bash aws math worker launcher. See #1923 . I'm at the stage where I have a bunch of code but still need to make the tests pass.

@jucor
Copy link
Contributor

jucor commented Feb 18, 2025

@tevko #1923 is ready :)

@tevko tevko marked this pull request as ready for review February 18, 2025 21:29
@tevko tevko requested a review from colinmegill February 18, 2025 21:29
@jucor
Copy link
Contributor

jucor commented Feb 18, 2025 •
edited
Loading

@tevko for my stats, given you merged #1923 , do you mind modifying the corresponding commit to mention the co-authorship please?
(Especially since I suspect this means #1923 might never get merged?)
See https://github.blog/news-insights/product-news/commit-together-with-co-authors/
and https://dev.to/srebalaji/how-to-add-multiple-authors-to-a-commit-in-github-5a4j
Thanks :)

@colinmegill
Copy link
Member

Today I learned! I never knew GitHub had that

@jucor
Copy link
Contributor

jucor commented Feb 18, 2025

Today I learned! I never knew GitHub had that

Yeah it's pretty cool for collaborative work :)

@jucor
Copy link
Contributor

jucor commented Feb 18, 2025

Ah, also, feel free to use the CLI (useful for non-CDK/TS users) and the integration tests :)

@tevko tevko deployed to production February 28, 2025 02:46 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmegill colinmegill colinmegill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tevko @jucor @colinmegill