rewords toolchain -development to 0.0.0 #900
Conversation
|
Thoughts on this? This is just the toolchain fix... I'll investigate the test stuff... |
|
This seems fairly reasonable to me. Going to kick off a test run once we get the CI back into working shape. |
|
Can you rebase the change please? I'd like to kick off a test run before merging. |
|
Yeah fs, doing so right now |
vincent-4
force-pushed
the
248/rename-toolchain-000
branch
2 times, most recently
from
168d417 to
08c9da9
Compare
- Use inputs.swift_version instead of hardcoded values - Update toolchain naming conventions - Replace development with semantic version format
vincent-4
force-pushed
the
248/rename-toolchain-000
branch
from
08c9da9 to
60f9958
Compare
|
I think I went overboard with the rebase stuff but it should be fine now... |
|
Shouldn't the expansion be |
Fixed it, my bad |
Oh... seems to fail cause it can't find files.. is the change propagating properly? |
|
Yes, the change is propagating properly - there is something else that likely needs to change (either the staging for the packaging or possibly the install locations for the other stages). You will need to go through the logs and figure out where the file got installed and downloaded to. |
|
Kicked off a test run at https://github.com/thebrowsercompany/swift-build/actions/runs/13405502524 |
|
Seems to have passed! I'm going to go ahead and merge this. |
Made to be consistent with what we do in do in build.ps1 - use Swift\Toolchains\0.0.0+Asserts: this is the debug build, so use Asserts (not noAsserts)
This is one of 3 changes required. See PR for discussion with @compnerd
Find the PR originally filed at:
thebrowsercompany/swift-build#251
Find the original issue at
thebrowsercompany/swift-build#248