remove hardcoded timeout by listening on transitions

[ianstormtaylor]

really cool component by @anthonyshort that lets us remove hardcoded timeouts for waiting for transitions, looking to use overlay with a .3s transition instead and figured this would make a good fix

[luka5]

this will probably fix issue #7

[ianstormtaylor]

shit, this doesn't fix it. unfortunately it seems like there's no way to do this without knowing the element is transitioning, so this is just currently impossible because the spec is poorly done.

[anthonyshort]

Flip the addClass and after calls and it should work. I've been using that component for a while on a bunch of things.

[ianstormtaylor]

mm definitely dumb on my part for having that before hand. seems to not work with version 0.2.0 of https://github.com/anthonyshort/has-transitions though since now the el itself is being checked?

if i use https://github.com/anthonyshort/after-transition 0.0.2 it works, but 0.0.3 doesnt

might be doing something else dumb, let me know. trouble again (i think) is that the animation is pure css, no inline styles

[anthonyshort]

I usually just toggle classes on and off and it works ok. The change I made to that component in those versions (I think) was changed from checking if the browser is capable of doing to transitions, to actually checking the el.style.transition property to see if the element has a transition set on it. There's usually no point in doing the afterTransition if the element doesn't actually have a transition property.

Soooo by doing the afterTransition and THEN doing the class, it will check the style, see there are no transition properties, and then just execute it straight away.

I think I just need to figure out which is better for the component - check the capabilities (even if the element has no transitions) or check the element for transitions.

[anthonyshort]

Actually, looking at how I'm checking it, it's only checking the el.style.transition, so if you're not using the shorthand and using transition-property, transition-duration etc, that might return false.

I might just make afterTransition assume you know what you're doing and just check for browser support for transitions.

[pirxpilot]

I pushed rebased and updated version of this to transition-end branch - and it seems to work for me, but...

• would be great if people checked on older browsers - I am happily Windows and IE free at the moment
• isn't it an overkill? I mean after-transition is great and useful component, but maybe here we can make older browsers' users happy by waiting 300ms instead of 2s