AR 6.1: Fix update_all
to update loaded associations
#620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #619
Overview
In ActiveRecord 6.1, calling
update_all
on association (ex.user.readings.update_all(rating: 3)
) not only updates the records in the DB, but also updates the loaded association objects. In other words, when you then useuser.readings
, they will have updatedrating
values.When
composite_primary_key
gem is used, this behaviour is different, even for models without composite primary key defined (becauseupdate_all
inActiveRecord::Relation
is overwritten for all AR models).This PR fixes it. I changed the
update_all
anddelete_all
methods to more closely resemble those from Rails 6.1 source (with the important difference of howwhere
constraints are built for composite primary key models).