Add "wrap/unwrap all" functions; always wrap/unwrap all in QuarkBuilder #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwang25
reviewed
Nov 19, 2024
kevincheng96
force-pushed
the
kevin/wrap-up-to-builder
branch
from
5672d15 to
703f5f5
Compare
cwang25
approved these changes
Nov 19, 2024
hayesgm
reviewed
Nov 20, 2024
kevincheng96
force-pushed
the
kevin/wrap-up-to-builder
branch
from
703f5f5 to
723e8b2
Compare
kevincheng96
changed the title
kevincheng96
changed the title
kevincheng96
force-pushed
the
kevin/wrap-up-to-builder
branch
from
723e8b2 to
ea77ab6
Compare
hayesgm
reviewed
Nov 21, 2024
kevincheng96
force-pushed
the
kevin/wrap-up-to-builder
branch
from
1700ab3 to
42a2c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We start using the new "wrap up to" scripts for ETH/WETH in the QuarkBuilder. In the case that ETH/WETh is bridged, we also need to always attempt to wrap/unwrap ETH/WETH on the destination chain because the QuarkBuilder cannot know ahead of time if Across will be sending ETH or WETH to the wallet.We implement new
wrap/unwrap allfunctions for ETH/WETH and stETH/wstETH. We also update the QuarkBuilder to always wrap/unwrap all (except for WETH, where we use "unwrap up to" because we prefer to preserve a user's WETH balance).