Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confetti fixes #219

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Confetti fixes #219

merged 6 commits into from
Jul 24, 2024

Conversation

ComputasAlex
Copy link
Collaborator

Requesting WINDOWS USER to test for lag.
Changing the confetti gun to a single pop. Less elements as well to make it runnable on windows PCs. Adds a reset when leaving the page.

Copy link
Contributor

@calvx calvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
There is no lag on windows computer, and confetti disappears when you click play again as expected.

@ComputasAlex ComputasAlex merged commit fb9f6d4 into develop Jul 24, 2024
4 checks passed
@ComputasAlex ComputasAlex deleted the SP24-684-remove-confetti-earlier branch July 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants