Feature/static filter for the TREE specification #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction are defined.
…commited last time
rubensworks
requested changes
Nov 9, 2022
There was a problem hiding this comment.
Things are still very vague to me as to how everything works.
I think adding some more documentation would help a lot.
Also, I'm not convinced yet about the optimize-link-traversal bus, as it seems to be tailored specifically to tree, and is not link-traversal-wide.
Can we move this logic into the tree-specific actor on the link extraction bus?
If not, can we make this optimize bus independent of tree?
packages/actor-extract-links-extract-tree/lib/ActorExtractLinksTree.ts
Outdated
Show resolved
Hide resolved
...r-optimize-link-traversal-filter-tree-links/lib/ActorOptimizeLinkTraversalFilterTreeLinks.ts
Outdated
Show resolved
Hide resolved
packages/actor-extract-links-extract-tree/lib/treeMetadataExtraction.ts
Outdated
Show resolved
Hide resolved
packages/actor-extract-links-extract-tree/lib/treeMetadataExtraction.ts
Outdated
Show resolved
Hide resolved
...r-optimize-link-traversal-filter-tree-links/lib/ActorOptimizeLinkTraversalFilterTreeLinks.ts
Outdated
Show resolved
Hide resolved
...r-optimize-link-traversal-filter-tree-links/lib/ActorOptimizeLinkTraversalFilterTreeLinks.ts
Outdated
Show resolved
Hide resolved
...r-optimize-link-traversal-filter-tree-links/lib/ActorOptimizeLinkTraversalFilterTreeLinks.ts
Outdated
Show resolved
Hide resolved
…val with one value, now it is process as if it was a single value
…lee-implementation
constraintAutomaton
deleted the
feature/time-filtering-tree-sparqlee-implementation
branch
constraintAutomaton
restored the
feature/time-filtering-tree-sparqlee-implementation
branch
rubensworks
force-pushed
the
master
branch
4 times, most recently
from
2f6bcb6
to
6da1c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static filter for the TREE specification
The objective of this PR is to implement SPARQL filters in a way that when the query contains a filter expression, the next nodes describe by the current TREE relation that cannot be satisfy with the filter will not be followed. The filters are called static because they are applied before the execution of the query, so the binding during execution has no impact on the pursuit of nodes.
Implementation
The TREE traversal extractor provided an
ITreeNodeobject containing "all" the relevant metadata information.The FilterNode class provide to the solver the TREE relation, the filter expression and the effective variable. The solver than interpret the
TREE relationand the filter expression as a boolean expression. The solution domain is after evaluating first for only the filter expression than with the filter expression and the TREE relation. If the domain is empty than a false value associated with the relation is inserted in a map in theFilterNodeclass (as it is impossible that a document can match the filter will be found). The operation is repeated for all the relation and a map of those results are forwarded to the TREE extractor actor that prune the irrelevant links.Limitation
Perceptive
linked to #82