-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
date: support gcc14 on test_package #23946
Conversation
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
Hi @toge thanks a lot! Posting the before and after logs for gcc would be great, as we're not yet building that configuration to test it ourselves, so it would help a ton for future traceability, thanks! |
@toge note that the new CI system requires the recipe folder to be up-to-date, so you'll need to rebase in cases like this. For now, I've merged from master as I want to try these kinds of changes in the new CI, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it shouldn't be necessary to publish a new recipe revision for this!
note to team: the pipeline should be able to handle fixing a test package without requiring to publish recipe revisions (or rebuilding packages from new revisions)
note to self - fixing this asap ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix to support test_package only changes is now live, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I've modified the test package to minimise it as much as possible - ensuring that when there is a library to test, we check a symbol from that library, and nothing else.
This helps with ongoing maintenance and hopefully will be more robust to compiler updates...
(I did test it with gcc-14 on Linux)
* date: support gcc14 on test_package * Discard changes to recipes/date/all/conanfile.py * date: simplify test package * Dont print exception error (no need) --------- Co-authored-by: Abril Rincón Blanco <[email protected]> Co-authored-by: Abril Rincón Blanco <[email protected]> Co-authored-by: Luis Caro Campos <[email protected]>
* date: support gcc14 on test_package * Discard changes to recipes/date/all/conanfile.py * date: simplify test package * Dont print exception error (no need) --------- Co-authored-by: Abril Rincón Blanco <[email protected]> Co-authored-by: Abril Rincón Blanco <[email protected]> Co-authored-by: Luis Caro Campos <[email protected]>
Specify library name and version: date/*
In gcc14 and msvc, there are compilation errors on building test_package.