Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date: support gcc14 on test_package #23946

Merged
merged 5 commits into from
Nov 12, 2024
Merged

date: support gcc14 on test_package #23946

merged 5 commits into from
Nov 12, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented May 10, 2024

Specify library name and version: date/*

In gcc14 and msvc, there are compilation errors on building test_package.


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (50b3550f1035121b00e943c9d4cbd0751d1615b9):

  • date/2.4.1:
    All packages built successfully! (All logs)

  • date/3.0.1:
    All packages built successfully! (All logs)

  • date/3.0.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (50b3550f1035121b00e943c9d4cbd0751d1615b9):

  • date/2.4.1:
    All packages built successfully! (All logs)

  • date/3.0.1:
    All packages built successfully! (All logs)

  • date/3.0.0:
    All packages built successfully! (All logs)

@AbrilRBS
Copy link
Member

Hi @toge thanks a lot! Posting the before and after logs for gcc would be great, as we're not yet building that configuration to test it ourselves, so it would help a ton for future traceability, thanks!

@AbrilRBS
Copy link
Member

AbrilRBS commented Nov 4, 2024

@toge note that the new CI system requires the recipe folder to be up-to-date, so you'll need to rebase in cases like this. For now, I've merged from master as I want to try these kinds of changes in the new CI, thanks!

AbrilRBS
AbrilRBS previously approved these changes Nov 4, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldn't be necessary to publish a new recipe revision for this!

note to team: the pipeline should be able to handle fixing a test package without requiring to publish recipe revisions (or rebuilding packages from new revisions)

@jcar87
Copy link
Contributor

jcar87 commented Nov 4, 2024

note to team: the pipeline should be able to handle fixing a test package without requiring to publish recipe revisions (or rebuilding packages from new revisions)

note to self - fixing this asap ;)

AbrilRBS
AbrilRBS previously approved these changes Nov 12, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix to support test_package only changes is now live, thanks!

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I've modified the test package to minimise it as much as possible - ensuring that when there is a library to test, we check a symbol from that library, and nothing else.
This helps with ongoing maintenance and hopefully will be more robust to compiler updates...
(I did test it with gcc-14 on Linux)

@AbrilRBS AbrilRBS merged commit 5191afe into conan-io:master Nov 12, 2024
9 checks passed
Ahajha pushed a commit to Ahajha/conan-center-index that referenced this pull request Nov 15, 2024
* date: support gcc14 on test_package

* Discard changes to recipes/date/all/conanfile.py

* date: simplify test package

* Dont print exception error (no need)

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Luis Caro Campos <[email protected]>
Ahajha pushed a commit to Ahajha/conan-center-index that referenced this pull request Nov 15, 2024
* date: support gcc14 on test_package

* Discard changes to recipes/date/all/conanfile.py

* date: simplify test package

* Dont print exception error (no need)

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Luis Caro Campos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants