pybind11_json: avoid linking pybind11_all_do_not_use #25703

ZbigniewRA · 2024-10-23T08:52:37Z

Summary

Changes to recipe: pybind11_json/0.2.x

Motivation

CMakeDeps incorrectly links to pybind11_all_do_not_use. See: #25685
This is technically a breaking change, since test_package requires now linking to pybind11::embed. But this is how it should be, as the client project should choose whether pybind11::embed or pybind11::module should be linked.

Details

Linking pybind11_json doesn't link to pybind11_all_do_not_use any more.
Added version 0.2.14.

Read the contributing guidelines
Checked that this PR is not a duplicate: list of PRs by recipe
Tested locally with at least one configuration using a recent version of Conan

…agging pybind11_all_do_not_use target.

…json. It still is added to pybind11_LIBRARIES.

conan-center-bot · 2024-10-23T19:06:31Z

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 4 (d2272c0fc65f298cd02062be453d76679a90d324):

pybind11_json/0.2.14:
CI failed to create some packages (All logs)

Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=5
os=Linux

[...]
-- Performing Test HAS_FLTO
-- Performing Test HAS_FLTO - Success
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-06052230/recipes/pybind11_json/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8

----Running------
> cmake --build '/home/conan/workspace/prod-v1/bsr/cci-06052230/recipes/pybind11_json/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8' '--' '-j3'
-----------------
Scanning dependencies of target test_package
[ 50%] Building CXX object test_package/CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable ../bin/test_package
[100%] Built target test_package
pybind11_json/0.2.14 (test package): Running test()

----Running------
> bin/test_package
-----------------
Converted nlohmann::json contents: [{"hello":"world","number":1234}]
Converted py::dict contents: {hello:world, number:1234}
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DATAROOTDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR


WARN: **************************************************
WARN: *** Conan 1 is legacy and on a deprecation path **
WARN: *********** Please upgrade to Conan 2 ************
WARN: **************************************************
pybind11_json/0.2.14 (test package): WARN: 
     ************************************************
     The 'cmake_find_package_multi' generator is deprecated.
     Please update your code and remove it.
     *************************************************

pybind11_json/0.2.14 (test package): WARN: 
     ************************************************
     The 'cmake' generator is deprecated.
     Please update your code and remove it.
     *************************************************

pybind11_json/0.2.14 (test package): WARN: **** The 'from conans import CMake' helper is deprecated. Please update your code and remove it. ****

pybind11_json/0.2.13:
Didn't run or was cancelled before finishing
pybind11_json/0.2.12:
Didn't run or was cancelled before finishing
pybind11_json/0.2.11:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 4 (d2272c0fc65f298cd02062be453d76679a90d324):

pybind11_json/0.2.14:
Didn't run or was cancelled before finishing

pybind11_json/0.2.13:
CI failed to create some packages (All logs)

Logs for packageID da39a3ee5e6b4b0d3255bfef95601890afd80709:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux

[...]
    brotli/1.1.0, bzip2/1.0.8, expat/2.6.3, fontconfig/2.13.93, freetype/2.13.2, gdbm/1.23, libffi/3.4.4, libpng/1.6.44, libxcrypt/4.4.36, mpdecimal/2.5.1, openssl/3.3.2, sqlite3/3.45.2, tcl/8.6.10, util-linux-libuuid/2.39.2, xz_utils/5.4.5, zlib/1.3.1, autoconf/2.71, automake/1.16.5, bison/3.8.2, brotli/1.1.0, bzip2/1.0.8, expat/2.6.3, flex/2.6.4, fontconfig/2.13.93, freetype/2.13.2, gdbm/1.23, gnu-config/cci.20210814, gperf/3.1, libffi/3.4.4, libpng/1.6.44, libtool/2.4.7, libxcrypt/4.4.36, m4/1.4.19, meson/1.2.2, meson/1.3.2, meson/1.4.0, mpdecimal/2.5.1, ncurses/6.4, ninja/1.12.1, openssl/3.3.2, pkgconf/2.0.3, pkgconf/2.1.0, sqlite3/3.45.2, tcl/8.6.10, tk/8.6.10, util-linux-libuuid/2.39.2, xz_utils/5.4.5, zlib/1.3.1
ERROR: Missing binary: cpython/3.12.7:6b9e109f755a98b007cd53f77efda3ed76083a8e

cpython/3.12.7: WARN: Can't find a 'cpython/3.12.7' package binary '6b9e109f755a98b007cd53f77efda3ed76083a8e' for the configuration:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.version=11
os=Linux
[options]
docstrings=True
lto=False
optimizations=False
pymalloc=True
shared=True
with_bz2=True
with_curses=True
with_gdbm=True
with_lzma=True
with_nis=False
with_sqlite3=True
with_tkinter=True
[requires]
brotli/1.1.0#d56d7bb9ca722942aba17369cb5c0519:5b903b7d3547e48038c8edfc531cf76728b899e8
bzip2/1.0.8#d00dac990f08d991998d624be81a9526:763ddd53d7a4775fe84a285f56005a096d9786fd
expat/2.6.3#39b80d3109fbe578fddfe4951f0b1d57:2ed03cd8691ea01deb11f88b5c95aa5195ec4816
fontconfig/2.13.93#11c27af044325e679237d01580e91306:7cadacf2600a24b79450826bd6dde0d1b66da0c9
freetype/2.13.2#5d2563803c8558d4ef47271a82c73d20:739e41967cd8e90e567861f59c4c6a1087fe7977
gdbm/1.23#e33e95cba20c006ae47466e2770cd984:cfd7b6736f088cc904c990fc83a7462c5a7ed842
libffi/3.4.4#72cccac6139293b6e97ec9cd676547ff:b647c43bfefae3f830561ca202b6cfd935b56205
libpng/1.6.44#9e1aa08fb46946c7c91e4ae03bd49811:19b397f6e54f5b8b2c6f7b81c4dce4c52d386e4f
libxcrypt/4.4.36#4b4e8f20794f1997dd59eeed0b7cdcfb:b647c43bfefae3f830561ca202b6cfd935b56205
mpdecimal/2.5.1#5ea215d2c261afaa9a739fb74fd1f338:4701af9408c47fd584e541225d5d1ae61dba9fad
ncurses/6.4#78908f3ed548f188cf15e415f8949f2f:f4cada79e61348df04d31c8afb663bcf66e9a6e1
openssl/3.3.2#9f9f130d58e7c13e76bb8a559f0a6a8b:ba0c965640dfc9185194d683d05bfbe6419b47a3
sqlite3/3.45.2#60f2d3278e7bc12c8ef02ac75119c137:46fbaf6d13261d8e27269f7addcf948d9d8e7b59
tcl/8.6.10#d694cc97f48640f0d66aa90b16cdc5cd:f1d0bc357fefa3c5eb52ac249889aa7f4d51014a
tk/8.6.10#1e8cbe0b5d8257de6bc6904da048766f:bc35fac6315178de42434589f802dbd60e891f7a
util-linux-libuuid/2.39.2#339f80aea7e5cf507b5b9839a128909f:b647c43bfefae3f830561ca202b6cfd935b56205
xorg/system
xz_utils/5.4.5#b885d1d79c9d30cff3803f7f551dbe66:b647c43bfefae3f830561ca202b6cfd935b56205
zlib/1.3.1#f52e03ae3d251dec704634230cd806a2:b647c43bfefae3f830561ca202b6cfd935b56205

ERROR: Missing prebuilt package for 'cpython/3.12.7'. You can try:
    - List all available packages using 'conan list "cpython/3.12.7:*" -r=remote'
    - Explain missing binaries: replace 'conan install ...' with 'conan graph explain ...'
    - This is a **test_package** missing binary. You can use --build (for all dependencies) or --build-test (exclusive for 'test_package' dependencies) to define what can be built from sources

More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'

pybind11_json/0.2.12:
Didn't run or was cancelled before finishing
pybind11_json/0.2.11:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

ZbigniewRA · 2024-10-24T06:52:14Z

Some help with fixing this PR would be nice. See: #25685

Ahajha · 2024-10-27T16:58:32Z

The missing binary for cpython is due to requesting just cpython/*:shared. The Conan 2 pipeline only builds that binary with all of its dependencies as shared too. Kinda annoying. So either you need to set a bunch of dependencies as shared, or the binary needs to be manually generated. They would need to be generated for all platforms. You also might run into invalid configurations in the test package, I suppose we'll see.

ZbigniewRA added 3 commits October 18, 2024 00:22

pybind11_json: Added version 0.2.14.

c94ab07

pybind11_json: Failed attempt at fixing problem with pybind11_json dr…

ae8e884

…agging pybind11_all_do_not_use target.

pybind11_all_do_not_use is no longer added as dependency of pybind11_…

a654dbd

…json. It still is added to pybind11_LIBRARIES.

conan-center-bot added the Failed label Oct 23, 2024

This comment has been minimized.

Sign in to view

Adding Python dependency to pybind11_json's test_package.

d2272c0

conan-center-bot added Service Under Maintenance and removed Failed labels Oct 23, 2024

This comment has been minimized.

Sign in to view

conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center and removed Service Under Maintenance labels Oct 23, 2024

This comment has been minimized.

Sign in to view

ZbigniewRA mentioned this pull request Oct 23, 2024

[package] pybind11_json/0.2.13: CMakeDeps incorrectly links to pybind11_all_do_not_use #25685

Open

ZbigniewRA marked this pull request as draft October 23, 2024 18:58

AbrilRBS self-assigned this Oct 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pybind11_json: avoid linking pybind11_all_do_not_use #25703

pybind11_json: avoid linking pybind11_all_do_not_use #25703

ZbigniewRA commented Oct 23, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Oct 23, 2024

ZbigniewRA commented Oct 24, 2024

Ahajha commented Oct 27, 2024

pybind11_json: avoid linking pybind11_all_do_not_use #25703

Are you sure you want to change the base?

pybind11_json: avoid linking pybind11_all_do_not_use #25703

Conversation

ZbigniewRA commented Oct 23, 2024

Summary

Motivation

Details

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Oct 23, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ❌

ZbigniewRA commented Oct 24, 2024

Ahajha commented Oct 27, 2024