Add support for building Qt Advanced Docking System version 4.3.1 #25848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Nov 5, 2024
|
There were a couple of previous attempts at this that I did not notice when I started creating this PR. But they were both over a year old... |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: qt-advanced-docking-system/4.3.1
Motivation
Add support for building new version of Qt Advanced Docking System. I have not touched the old recipe, since it appears to be Conan 1 only. Maybe that should be removed.
Details
Add a new recipe for 4.x.x versions of the package, and move the previous "all" to a 3.x.x directory. Maybe the 3.x.x should be removed and 4.x.x renamed to all, but that decision should be made by someone who knows more about "the maintaining old packages strategy of Conan".
Also added a test_package that just tries to build against the package. The test does not run anything.
The one "weirdness" of this package is that I want it to be optional whether the Qt used comes from Conan or from another installation of Qt, from outside of Conan. I could not find an example of how to do this, so I added an option "qt_from_conan" that controls this. Please let me know if there is a better way to do this!