opusfile: fix building for Android with http=True #26245
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: opusfile/all
Motivation
Fixes building opusfile with
http=Truefor AndroidDetails
Build fails due to using C99 features but compiling in C89 mode. I've opened issue in upstream xiph/opusfile#52 as I'm not sure what's the right way to proceed here (if I can blindly replace 89 with 99). In the recipe I replace 89 with 99 only for Android (because again I'm not sure if there will be any side effects on other platforms), but doing it in
generateas access toself.settingsis forbidden insource.Also:
buildtosourcewhich is the recommended way nowadays