[runtime_deploy] Respect subfolders in order to preserve symlinks #17848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second part of changing the
runtime_deploy
, addressing the comment #16938 (comment).When having subfolders in the lib or bin package folder, the same the same will be preserved. This situation avoids broken symlinks, for instance, we consume libfoo.so, but it's a symlink and points to subfolber/libfoo.so.1.0.
Open to discussion:
When doing this fix occurred me the following case:
Users may have problems with LD_LIBRARY_PATH if there are separate libraries in the subfolder. Maybe, we could include a new conf, like
tools.deployer.runtime:flatten
, whenTrue
, we move all artifacts for the top folder, and fix the relative symlinks, for instance:Changelog: Fix: Preserve subfolders for runtime_deploy deployer
Docs: TODO
fixes #16938
Related to #17824
develop
branch, documenting this one.