Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to perform check step based on a tag regex #344

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

cdmessin
Copy link
Contributor

@cdmessin cdmessin commented Jul 3, 2023

Implements #294

This PR decouples the idea of all tags being semantic versions.

This implements a new source parameter tag_regex as a new way to monitor an image repository.
In addition to being able to monitor a single tag, or semantic version tags, we can now monitor for tags based on the regex provided.

README docs have been updated as well to explain this functionality

@cdmessin cdmessin force-pushed the cleanAddRegexOption branch from 73eaf54 to 67e3c33 Compare July 3, 2023 19:29
@xtremerui
Copy link
Contributor

Thank you for the PR. Could you add test for the function in this file?

@cdmessin
Copy link
Contributor Author

cdmessin commented Jul 6, 2023

Absolutely, working on that now and will add that in shortly.

@cdmessin
Copy link
Contributor Author

cdmessin commented Jul 6, 2023

Thank you for the PR. Could you add test for the function in this file?

A few unit tests have been added for this new functionality.

Copy link
Contributor

@xtremerui xtremerui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xtremerui xtremerui merged commit 6a26975 into concourse:master Jul 7, 2023
@exp0nge
Copy link
Contributor

exp0nge commented Mar 18, 2024

I've added a feature to work in conjunction with this feature: #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants