Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax nvcc's sysroot upper bound #950

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Relax nvcc's sysroot upper bound #950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions recipe/patch_yaml/nvcc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,46 @@ if:
- linux-aarch64
then:
- add_depends: "cudatoolkit ${version}.*"
---


# Relax `sysroot` pins of `nvcc_{{ target_platform }}`
# Done by arch to handle package name differences
if:
name: nvcc_linux-64
version_lt: 12.0.0
timestamp_lt: 1737594364000
has_depends: "sysroot_linux-64?( *)"
then:
- replace_depends:
old: sysroot_linux-64 2.17.*
new: sysroot_linux-64 >=2.17,<3.0a0
Comment on lines +41 to +43
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly the focus is relaxing the pins in earlier nvcc_* packages so they can be more easily installed with newer sysroots

- replace_depends:
old: sysroot_linux-64 >=2.17
new: sysroot_linux-64 >=2.17,<3.0a0
Comment on lines +44 to +46
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing against this per se, but it bears noting that glibc 3.0 is entirely a creature of mythology at this point. I doubt we will see it in the next 20+ years

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this will help keep my retirement serene 😌

---
if:
name: nvcc_linux-aarch64
version_lt: 12.0.0
timestamp_lt: 1737594364000
has_depends: "sysroot_linux-aarch64?( *)"
then:
- replace_depends:
old: sysroot_linux-aarch64 2.17.*
new: sysroot_linux-aarch64 >=2.17,<3.0a0
- replace_depends:
old: sysroot_linux-aarch64 >=2.17
new: sysroot_linux-aarch64 >=2.17,<3.0a0
---
if:
name: nvcc_linux-ppc64le
version_lt: 12.0.0
timestamp_lt: 1737594364000
has_depends: "sysroot_linux-ppc64le?( *)"
then:
- replace_depends:
old: sysroot_linux-ppc64le 2.17.*
new: sysroot_linux-ppc64le >=2.17,<3.0a0
- replace_depends:
old: sysroot_linux-ppc64le >=2.17
new: sysroot_linux-ppc64le >=2.17,<3.0a0
Loading