-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend azure.free_disk_space
to Windows as well
#1966
base: main
Are you sure you want to change the base?
Conversation
32ed6d4
to
2df379e
Compare
👍 Xref #1949, which also contains a work-around. |
Thanks Axel! 🙏 Was finding the deletion time on Azure to be pretty slow. Tried every trick I could think of with If you know of better ways to delete on Windows, please let me know Agree changing the build directory path is worth considering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to guard this on CONDA_BLD_PATH
somehow? I don't think it makes sense to spend time cleaning up C:\
if the build then happens in D:\
by default
conda-smithy/conda_smithy/schema.py
Line 226 in 058670d
"CONDA_BLD_PATH": "D:\\\\bld\\\\", |
Speaking of D:\
, I'm not sure there'd even be anything to clean up there? So I guess we'd have a three-stage ladder of escalating options, each taking more time but providing more disk space:
- default (build on
D:\
; fastest, least space) - switch
CONDA_BLD_PATH
toC:\
(slower, more space) - also set
azure.free_disk_space
(slowest, most space)
Agreed We may also want to put this under another option like |
In addition to Linux, enable
azure.free_disk_space
on Windows. This helps free up some space in cases where it is needed. Also it can fix build issues where a system Python is accidentally pulled into builds causing hard to diagnose issues.Also switch Miniforge downloads to use PowerShell. This removes the reliance on the system Python for this step (making the aforementioned cleanup possibly). Additionally it slims the step down a bit and makes it a bit easier to parse.
Checklist
news
entry