Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate cos7 and alma8 docker files #287

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 16, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested a review from a team as a code owner October 16, 2024 16:15
@isuruf
Copy link
Member Author

isuruf commented Oct 16, 2024

@conda-forge/core, this is ready

@jakirkham
Copy link
Member

When it comes to distributions, think it is better to keep them in separate Dockerfiles

For example this is now adding CentOS 7 repos to Alma, which don't make sense there. Plus the naming of the directories is confusing

If the goal is simply to consolidate more content, would suggest taking the yum step changed here and moving it into a script that all images call

@isuruf
Copy link
Member Author

isuruf commented Oct 16, 2024

For example this is now adding CentOS 7 repos to Alma, which don't make sense there. Plus the naming of the directories is confusing

We are not. The fix_rpm uses those repos only for centos7. We would have to add alma8 repos there in the future as well.

This PR reduces code duplication and the only thing that this PR does more is to copy centos7 repos and delete them without using them in alma8 which is okay IMO.

@isuruf
Copy link
Member Author

isuruf commented Oct 16, 2024

Also, it looks like there's a single Dockerfile for centos7 and ubi8 cuda images. Those are two different distributions, yet we use one Dockerfile

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the deduplication. Also, both images are RHEL-derivatives, so a lot is the same, and the differences are small enough that unification is beneficial IMO.

@isuruf
Copy link
Member Author

isuruf commented Oct 22, 2024

@jakirkham let me know if there are any other objections.

@h-vetinari
Copy link
Member

As a great illustration why this PR is beneficial, the addition of alma9-based images becomes absolutely trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants