-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post-link.sh script #118
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
c57dc25
to
24bf6bf
Compare
Allows for executing python scripts which import FreeCAD modules when activating the conda environment containing freecad. LIMITATIONS: Windows is not supported. See the following FreeCAD forum discussion: https://forum.freecad.org/viewtopic.php?p=493282#p493277
have you tried using |
That works too, but requires every script to I don't think that's ideal as this solution which doesn't require any special modifications to scripts like |
My idea was to switch over to things like |
I think that would cause confusion for developers since Unless, you're talking about making I think Python packages and modules that depend on FreeCAD should run without modification in all environments regardless of installation method. |
Normally it should work also with other installations (not only conda) |
Maybe its good to set this to on as default. |
Interesting. Yes, maybe that's a sensible default. I didn't realize this could be an option for everyone, regardless of whether they use conda. I think it's a good idea to enable that as a default, and socialize the following imports: from freecad import app as App
from freecad import gui as Gui Then people wouldn't have any problems with Python not being able to find the |
As an aside, with from FreeCAD import Console, Placement, Vector # ✔️ works It would be nice if we could also import these directly from from freecad.app import Console, Placement, Vector # ❌ doesn't work currently To work around that, we'd have to: from freecad import app
Console = app.Console
# Placement = ... |
hmm I guess it would be best to find a consensus about the future of freecad imports. Because in the end all python relevant modules should be installed into Actually I just refactored a workbench and I used
|
Motivation: Allows for executing python scripts which import FreeCAD modules when the conda environment containing
freecad
is activated.LIMITATIONS:
Windows is not supported, but could be added easily if someone can test it.
See the following FreeCAD forum discussion for context:
https://forum.freecad.org/viewtopic.php?p=493282#p493277
@looooo said this was a good idea and would try to integrate it a few years ago, but never did:
https://forum.freecad.org/viewtopic.php?p=493282#p493688
The script should support all major shells: bash, zsh, and fish.
If someone could verify this works before merging, then that would be appreiciated!