Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cruft files in the output #12

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

akhmerov
Copy link
Contributor

@akhmerov akhmerov commented Jan 27, 2024

Should close #11

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@12rambau
Copy link
Contributor

Is it something that should be done for every pyproject.toml base python package or is it only related to hatch ?

@akhmerov
Copy link
Contributor Author

I'm not sure. One thing that I did change was {{ PYTHON }} to python, otherwise I was getting jinja template errors of PYTHON not being defined.

@akhmerov
Copy link
Contributor Author

https://github.com/conda-forge/typing_extensions-feedstock/blob/main/recipe/meta.yaml that I used as a source doesn't have any extra pip flags.

@akhmerov
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jupyter-sphinx-feedstock/actions/runs/7680280199.

@akhmerov
Copy link
Contributor Author

Clobber warnings are gone from the logs, so I'll merge.

@akhmerov akhmerov merged commit 95bd08c into conda-forge:main Jan 27, 2024
3 checks passed
@akhmerov akhmerov deleted the fix_outputs branch January 27, 2024 18:06
@moorepants
Copy link

moorepants commented Jan 28, 2024

Is it something that should be done for every pyproject.toml base python package or is it only related to hatch ?

pip's normal behavior is to detect if a dependency is present in site-packages and, if so, it skips downloading it from pypi. This means that you can always manually setup your dependencies and then pip install to effectively get a no pip managed dependency install. I am not familiar with hatch but if it does not follow this behavior, i.e. downloads packages regardless of what is present in site-packages, then you will have to disable this in hatch. conda needs to completely manage the dependencies in the build and if there are other processes that also do so, there will be problems. We've been deleting the pyproject.toml file in many cases to avoid this, see conda-forge/conda-forge.github.io#1174 for some info. I think now people are using things like poetry and hatch in the conda build, but you have to carefully make sure it doesn't try to do any dependency management.

@akhmerov thanks for fixing this. All looks good now!

@moorepants
Copy link

FYI: https://github.com/conda-forge/conda-forge.github.io/pull/2044/files (has something to do with "outputs").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jupyter-sphinx-0.5.3-pyha770c72_3 packages many packages that are not jupyter-sphinx
3 participants