Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe for the ninja python module #24850

Closed
wants to merge 13 commits into from

Conversation

mediocretech
Copy link
Contributor

@mediocretech mediocretech commented Dec 21, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ninja-python) and found some lint.

Here's what I've got...

For recipes/ninja-python:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ninja-python) and found it was in an excellent condition.

@mediocretech
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

@isuruf
Copy link
Member

isuruf commented Jan 10, 2024

There's no reason to re-papckage a ninja when there's already a ninja package in conda-forge. Maybe we can use the same approach as NixOS/nixpkgs#246963

@mediocretech
Copy link
Contributor Author

@isuruf thanks for reaching out!

Apologies, I'm not following what the suggested path forward is. My understanding is ninja-python-distributions allows for python integration of ninja. Is your approach to update ninja-feedstack to build both?

FWIW, I'm unfamiliar with ninja, and trying to resolve downstream dependencies for another build which cannot import ninja.

@mediocretech
Copy link
Contributor Author

@isuruf and/or @conda-forge/help-python any thoughts on the above?

This was referenced Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants