Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python compute modules sdk to conda-forge #28006

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

lauraAriasFdez
Copy link

@lauraAriasFdez lauraAriasFdez commented Oct 25, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@lauraAriasFdez lauraAriasFdez changed the title python compute modules sdk open source Adding python compute modules sdk to conda-forge Oct 25, 2024
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/foundry-compute-modules/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: Palantir Technologies. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 25, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/foundry-compute-modules/meta.yaml) and found some lint.

Here's what I've got...

For recipes/foundry-compute-modules/meta.yaml:

  • There are too few lines. There should be one empty line at the end of the file.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/foundry-compute-modules/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/foundry-compute-modules/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: amazr. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/foundry-compute-modules/meta.yaml) and found some lint.

Here's what I've got...

For recipes/foundry-compute-modules/meta.yaml:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@scottkruyswyk
Copy link

ok with me 👍

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/foundry-compute-modules/meta.yaml) and found it was in an excellent condition.

@amazr
Copy link

amazr commented Oct 25, 2024

works for me +1

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Copy link
Contributor

github-actions bot commented Nov 6, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@lauraAriasFdez
Copy link
Author

@conda-forge/help-python

@lauraAriasFdez
Copy link
Author

@conda-forge-admin, please ping @conda-forge/help-python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 23, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/foundry-compute-modules/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/foundry-compute-modules/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12943073356. Examine the logs at this URL for more detail.

@lauraAriasFdez
Copy link
Author

@conda-forge-admin, please ping @conda-forge/help-python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

@xhochy
Copy link
Member

xhochy commented Dec 7, 2024

Please address the lint.

@lauraAriasFdez
Copy link
Author

@conda-forge-admin, please ping @conda-forge/help-python I have address the lint :)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

@lauraAriasFdez lauraAriasFdez requested a review from xhochy January 23, 2025 16:58
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 24, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/foundry-compute-modules/meta.yaml) and found some lint.

Here's what I've got...

For recipes/foundry-compute-modules/meta.yaml:

  • ❌ The about section contained an unexpected subsection name. documentation is not a valid subsection name.
  • ❌ The about section contained an unexpected subsection name. repository is not a valid subsection name.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12943216193. Examine the logs at this URL for more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants