Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds rdflib-pyld-compat #28543

Merged
merged 21 commits into from
Jan 11, 2025
Merged

Conversation

marimeireles
Copy link
Member

@marimeireles marimeireles commented Dec 12, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 12, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rdflib-pyld-compat/meta.yaml) and found some lint.

Here's what I've got...

For recipes/rdflib-pyld-compat/meta.yaml:

  • ❌ noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/rdflib-pyld-compat/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package rdflib-pyld-compat using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12298409854. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@marimeireles
Copy link
Member Author

Here's a note on the license. The repository doesn't have a LICENSE file, so I found it within the original setup.py and copied the license from https://www.apache.org/licenses/LICENSE-2.0.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/rdflib-pyld-compat/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: joshmoore. Please ask them to comment on this PR if they are.

@joshmoore
Copy link
Member

I agree

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

build:
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0
skip: True # [osx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to skip osx? Seems like this could be a noarch: python recipe.

Copy link
Member

@xhochy xhochy Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I've reintroduced it in the last commit. Thanks Uwe!
That was just an artifact of me poking around and I think I've found an error with the conda-build<>OSx M3?

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 12, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rdflib-pyld-compat/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/rdflib-pyld-compat/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12299484175. Examine the logs at this URL for more detail.

@marimeireles marimeireles mentioned this pull request Dec 12, 2024
10 tasks
@xhochy
Copy link
Member

xhochy commented Dec 13, 2024

Can you please address the lint? Then this would be ready.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rdflib-pyld-compat/meta.yaml) and found it was in an excellent condition.

@marimeireles
Copy link
Member Author

@xhochy I believe this is ready to merge now.
Thanks for the patience!

@xhochy xhochy merged commit 30c890c into conda-forge:main Jan 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants