-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds rdflib-pyld-compat #28543
Adds rdflib-pyld-compat #28543
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/rdflib-pyld-compat/meta.yaml:
For recipes/rdflib-pyld-compat/meta.yaml:
Documentation on acceptable licenses can be found here. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12298409854. Examine the logs at this URL for more detail. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Here's a note on the license. The repository doesn't have a LICENSE file, so I found it within the original setup.py and copied the license from https://www.apache.org/licenses/LICENSE-2.0. |
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
I agree |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
recipes/rdflib-pyld-compat/meta.yaml
Outdated
build: | ||
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation | ||
number: 0 | ||
skip: True # [osx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason to skip osx
? Seems like this could be a noarch: python
recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I've reintroduced it in the last commit. Thanks Uwe!
That was just an artifact of me poking around and I think I've found an error with the conda-build<>OSx M3?
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/rdflib-pyld-compat/meta.yaml:
Documentation on acceptable licenses can be found here. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12299484175. Examine the logs at this URL for more detail. |
Can you please address the lint? Then this would be ready. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@xhochy I believe this is ready to merge now. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).