Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tt-metalium #28854

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
aad8e55
Add first shot
blozano-tt Jan 17, 2025
88b02fd
Adjust
blozano-tt Jan 17, 2025
4cbe34f
Progress
blozano-tt Jan 18, 2025
43ca25a
dunno
blozano-tt Jan 22, 2025
6fb0f13
dunno
blozano-tt Jan 22, 2025
d0dada2
Fix
blozano-tt Jan 22, 2025
b935312
Add libmpc as a dependency for sfpi
blozano-tt Jan 22, 2025
9bcf248
Try LD_LIBRARY_PATH
blozano-tt Jan 22, 2025
f7a7349
Try higher sysroot
blozano-tt Jan 22, 2025
605a5f8
Not sure
blozano-tt Jan 22, 2025
5d06a8c
Add missing dep zlib
blozano-tt Jan 22, 2025
8ccf7fc
Update to build and install python wheel
blozano-tt Jan 22, 2025
dc68535
Add python build deps
blozano-tt Jan 23, 2025
d1b88a2
Please
blozano-tt Jan 23, 2025
f522568
Reduce load on CPU
blozano-tt Jan 23, 2025
e858c4b
Try restricting python
blozano-tt Jan 23, 2025
2d3f737
Progress maybe
blozano-tt Jan 23, 2025
bbc7d92
Fix skip issue
blozano-tt Jan 23, 2025
04d3263
Fix python module installation hopefully
blozano-tt Jan 23, 2025
ff638a1
Merge branch 'main' into tt-metalium
blozano-tt Jan 23, 2025
8678be7
Hacks to fix python packaging maybe
blozano-tt Jan 24, 2025
293f3f7
Merge branch 'tt-metalium' of https://github.com/blozano-tt/staged-re…
blozano-tt Jan 24, 2025
65387d1
Merge branch 'main' into tt-metalium
jakirkham Jan 24, 2025
9842d1d
Update recipes/tt-metalium/meta.yaml
blozano-tt Jan 24, 2025
163f19b
Update recipes/tt-metalium/meta.yaml
blozano-tt Jan 24, 2025
2a3032d
Update meta.yaml
blozano-tt Jan 24, 2025
ed3b681
Add missing runtime deps for RISCV compiler binaries
blozano-tt Jan 24, 2025
3246ece
Use branch temporarily, relax other constraints
blozano-tt Jan 25, 2025
de4c472
Enable only python 3.10
blozano-tt Jan 26, 2025
9924066
Move back to tarball with latest code
blozano-tt Jan 29, 2025
37eb9c7
Update url logic
blozano-tt Jan 30, 2025
a5f7a46
Update recipes/tt-metalium/build.sh
blozano-tt Jan 30, 2025
4902999
Update recipes/tt-metalium/meta.yaml
blozano-tt Jan 30, 2025
29beb3e
Create multiple outputs to keep cpp sources seperate
blozano-tt Feb 1, 2025
f981c08
Update meta.yaml
blozano-tt Feb 1, 2025
60c4a31
Revert "Update meta.yaml"
blozano-tt Feb 1, 2025
e41eca4
Revert "Create multiple outputs to keep cpp sources seperate"
blozano-tt Feb 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions recipes/tt-metalium/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#!/bin/env/bash
set -e

# Needed so that sfpi can be invoked at build time to generate object files
# sfpi links libmpc.so at runtime
export LD_LIBRARY_PATH=$PREFIX/lib

# Avoid overloading build machine processors and memory
export NUM_PROCS=$((CPU_COUNT / 2))

# Needed by python setup.py
export TT_FROM_PRECOMPILED_DIR=$SRC_DIR

cmake \
$CMAKE_ARGS \
-G Ninja \
-S $SRC_DIR \
-B $SRC_DIR/build \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_SKIP_INSTALL_RPATH=ON

cmake --build $SRC_DIR/build --parallel $NUM_PROCS

cmake --install $SRC_DIR/build

# Warning - HACK!
mkdir -p $SRC_DIR/build/lib
cp $PREFIX/lib/_ttnn.so $SRC_DIR/build/lib/
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved

pip install --no-deps $SRC_DIR
2 changes: 2 additions & 0 deletions recipes/tt-metalium/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
c_stdlib_version: # [linux]
- 2.34 # [linux]
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved
67 changes: 67 additions & 0 deletions recipes/tt-metalium/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# Note: there are many handy hints in comments in this example -- remove them when you've finalized your recipe
# If your package is python based, we recommend using Grayskull to generate it instead:
# https://github.com/conda-incubator/grayskull

# Jinja variables help maintain the recipe as you'll update the version only here.
# Using the name variable with the URL in line 16 is convenient
# when copying and pasting from another recipe, but not really needed.
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved
{% set name = "tt-metalium" %}
{% set version = "0.55.0" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
- url: https://github.com/tenstorrent/tt-metal/releases/download/v{{ version }}-rc13/tt-metalium.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is using an RC (rc13)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am putting a lot of fixes into main to support this effort. I needed a very recent version of the code. We upload release candidates daily. We cut releases very rarely.

sha256: 5b4b4454c6fe60e91730b676ccc126fdc41149738e06f3e8d34bb9979bf30259
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved

build:
number: 0
skip: true # [not linux or py!=310]
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved

requirements:
build:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- {{ stdlib("c") }}
- cmake
- ninja
- git

host:
- python
- pip
- wheel
- setuptools =69.5.1
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved
- numactl
- libhwloc
- mpc
- numpy
- loguru
- networkx
- pytorch-cpu
- python-graphviz
h-vetinari marked this conversation as resolved.
Show resolved Hide resolved

run:
- python

test:
imports:
- ttnn
Comment on lines +55 to +57
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the installed files I see

lib/python3.10/site-packages/runtime/sfpi/compiler/lib/gcc/riscv32-unknown-elf/12.2.0/include/stdint.h 

and a whole lot more along those lines. It seems to me that this shouldn't be under site-packages (which is python-specific), unless tt-metalium depends on exactly that layout?

Similarly for lib/python3.10/site-packages/tt_metal, which looks to be just full of .h & .cpp files. Why not put all that into a separate output that install these things into $PREFIX/{include,lib,...}, and then depend on that in tt-metalium (again, we could make a symlink to the location in $SP_DIR if necessary).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, we need many such files to support JIT compile at runtime.

The project depends on the current structure.

For PyPi we produce a wheel with all necessary files. (There is pending work to trim the number of files).

I don't want Anaconda's behavior to differ from normal pip / python behavior.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project depends on the current structure.

That's OK, but symlinks will still work for this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-vetinari I am not a fan of what you are asking me to do, because it makes the Anaconda packaging diverge from our existing packaging for Pypi. The C++ sources that are packaged are not to be compiled by the host, so they don't really belong in conda environment's include/

It would be quite a bit of work to break out all non-python sources into different outputs, and for no functional benefit. I would also have to create a patch file, to change the existing setup.py driven packaging.

I pushed two commits tonight to start giving things a try. Let me know if thats what you were imaginging.

My request to you, is lets just not do this for now? We can work on improving our python packaging and distribution scheme and port the upstream improvements to this recipe in time?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: I reverted the commits, because the build was failing.


about:
home: https://github.com/tenstorrent/tt-metal
summary: 'Simple, fast, extensible runtime libraries for Tenstorrent Hardware'
description: |
TT-NN operator library, and TT-Metalium low level kernel programming model.
license: Apache-2.0
license_family: Apache
license_file: LICENSE
doc_url: https://docs.tenstorrent.com/tt-metalium/latest
dev_url: https://github.com/tenstorrent/tt-metal

extra:
recipe-maintainers:
- blozano-tt
- afuller-TT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm I am willing to be listed here. ✅

Loading