Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bld.bat from conda/svn recipe #13

Closed
wants to merge 1 commit into from

Conversation

briantoby
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@briantoby briantoby requested review from scopatz and zklaus as code owners May 20, 2022 20:01
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@briantoby
Copy link
Author

needs more work

@briantoby briantoby closed this May 20, 2022
@zklaus
Copy link
Contributor

zklaus commented May 20, 2022

Thanks, @briantoby for taking this up. It's really great to see a move to bring this package to windows as well! 👍

You don't have to close the PR when it doesn't work immediately. If you push new commits to the branch, they will show up here. Then, we can discuss them and see what additional work is needed. It is not unusual for a PR to stay open for weeks, with numerous commits being added and different things being tried over that period. Don't worry if you run into problems. Generally speaking, if there is someone interested in a feature like you clearly are, the team will step up to help us all achieve it.

The expectation is not that this is a lone-wolf effort, where you have to solve everything before you can bring it to the table. If you show some effort, as in this PR and #14, we'll be happy to help push it to completion.

Thanks again, and let's reopen either this PR or #14 as you see fit.

@briantoby
Copy link
Author

@zklaus thanks for the advice and explanation. I did not realize that the PR "review" process could be collaborative. I have #15 now open and we will see if I get any farther.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants