Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM OSX Migrator #30

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Sep 10, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

recipe/meta.yaml Outdated
@@ -20,6 +20,7 @@ requirements:
- {{ stdlib("c") }}
- {{ compiler('cxx') }}
- autoconf # [unix]
- gettext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want this and libintl-devel # [not linux] in host.

Suggested change
- gettext
- gettext-tools

Copy link
Contributor

@rfiorella rfiorella Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy quick clarification - are you suggesting that gettext-tools should also be moved from build to host? Or just changed from gettext to gettext-tools?

@xylar
Copy link

xylar commented Sep 11, 2024

@xhochy makes a suggestion and I get credit! That's a good deal for me!

@zklaus
Copy link
Contributor

zklaus commented Sep 11, 2024

Oh, sorry, @xhochy! My bad!

@rfiorella rfiorella force-pushed the bot-pr_arm_osx_h6799dd branch from f6a33ca to 0e457c4 Compare October 8, 2024 19:43
@rfiorella
Copy link
Contributor

Rebasing to build against new version merged by bot in #31

@danielnachun
Copy link
Contributor

@conda-forge-admin please rerender

@rfiorella
Copy link
Contributor

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12790543940. Examine the logs at this URL for more detail.

@rfiorella
Copy link
Contributor

@conda-forge-admin, please restart ci

@rfiorella
Copy link
Contributor

rfiorella commented Jan 16, 2025

Closing without merge as this has been resolved by #35.
Okay with this @conda-forge/help-osx-arm64?

@rfiorella rfiorella closed this Jan 16, 2025
@rfiorella
Copy link
Contributor

I am actually going to re-open this as the merge CI failed after the PR CI had initially passed.

cc: @danielnachun

@rfiorella rfiorella reopened this Jan 16, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@danielnachun
Copy link
Contributor

Reopening here won't help unfortunately - the failure after merging is due to conda/conda-build#5594. Once that is fixed, we can just rerun that command in the dashboard. Now that I'm a maintainer I'm happy to do that - it will be simpler than fixing all the merge conflicts here.

@rfiorella
Copy link
Contributor

Sounds good, I had reopened this PR mainly as a reminder that the mac-os/arm64 merge still needs to be fixed.

Agree that it's not worth fixing the merge commits here since they're obsolete anyway - sorry, should have been a bit more clear!

Thanks!

@danielnachun
Copy link
Contributor

I reran CI and it finished the macOS builds now so we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants