Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tensorflow-metadata #22

Merged
merged 18 commits into from
Feb 9, 2025
Merged

Update tensorflow-metadata #22

merged 18 commits into from
Feb 9, 2025

Conversation

ehfd
Copy link
Member

@ehfd ehfd commented Feb 4, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #16
Closes #19
Closes #20
Closes #21

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 4, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13131071077. Examine the logs at this URL for more detail.

conda-forge-webservices[bot] and others added 2 commits February 4, 2025 08:15
@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13131219784. Examine the logs at this URL for more detail.

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13131504141. Examine the logs at this URL for more detail.

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits February 4, 2025 09:01
@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 4, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ Detected pure Python wheel(s) in source: https://pypi.org/packages/py3/t/tensorflow-metadata/tensorflow_metadata-{{ version }}-py3-none-any.whl. This is generally ok for pure Python wheels and noarch=python packages but it's preferred to use a source distribution (sdist) if possible.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13160210122. Examine the logs at this URL for more detail.

@ehfd ehfd changed the title Upgrade tensorflow-metadata Update tensorflow-metadata Feb 4, 2025
conda-forge-webservices[bot] and others added 2 commits February 4, 2025 09:37
@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13132718874. Examine the logs at this URL for more detail.

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge/tensorflow-metadata Ready to be merged.

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13132925874. Examine the logs at this URL for more detail.

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13133070304. Examine the logs at this URL for more detail.

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

INFO :: The inputs making up the hashes for the built packages are as follows:
{
  "tensorflow-metadata-1.16.1-pyh753f3f9_0.conda": {
    "recipe": {
      "channel_targets": "conda-forge main",
      "tensorflow": "2.16"
    }
  }
}

@ngam @hmaarrfk @h-vetinari Why does this exist? tensorflow-metadata has nothing to do with dependence on TensorFlow.

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

@conda-forge-admin, please rerender

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

Looks like it reappears after the rerender.

@ehfd
Copy link
Member Author

ehfd commented Feb 4, 2025

conda-forge/conda-smithy#2195
conda-forge/conda-smithy#2071

This is the closest thing I found in conda-smithy.

@ehfd
Copy link
Member Author

ehfd commented Feb 5, 2025

@conda-forge-admin, please rerender

@ngam ngam requested a review from hmaarrfk February 8, 2025 03:37
@ehfd
Copy link
Member Author

ehfd commented Feb 8, 2025

@ngam Mark is not a maintainer here so he has ultimately entrusted to your decision.

@ngam
Copy link
Contributor

ngam commented Feb 9, 2025

But Mark works in these feedstocks, so his opinion is very important. I will merge

@ngam ngam merged commit a1bd3c0 into conda-forge:main Feb 9, 2025
4 checks passed
@ngam
Copy link
Contributor

ngam commented Feb 9, 2025

Also, welcome ehfd

@ehfd ehfd deleted the pr branch February 9, 2025 05:35
@ehfd
Copy link
Member Author

ehfd commented Feb 9, 2025

@ngam Thank you for the introduction! I am delighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect dependencies for tensorflow-metadata >=0.13.0
4 participants