Skip to content

Commit

Permalink
Address a few review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
peytondmurray committed Nov 12, 2024
1 parent 8157f0a commit acb0beb
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/test_conda_store_server_integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,6 @@ jobs:
python -m pytest -m "user_journey"
if: matrix.test-type == 'user-journey'

# These mirror the tests run while building the conda package
# See https://github.com/conda-forge/conda-store-feedstock/ for details
- name: "Run basic import tests ✅"
run: |
python -c "import conda_store_server"
conda-store-server --help
conda-store-worker --help
- name: "Get Docker logs 🔍"
if: ${{ failure() }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion conda-store-server/environment-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ channels:
- nodefaults
dependencies:
# must be kept in sync with the min supported version in pyproject.toml
- python >=3.8
- python >=3.12
# conda builds
- conda
# dev dependencies
Expand Down
2 changes: 1 addition & 1 deletion conda-store-server/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ dependencies = [
"pymysql",
# pyyaml>5.3.1 is broken with cython>=3 transitive dependency
# See https://github.com/yaml/pyyaml/issues/724 for details
"pyyaml<=5.3.1",
"pyyaml <=5.3.1",
"redis",
"requests",
"pydantic >=1.10.16,<2.0a0",
Expand Down

0 comments on commit acb0beb

Please sign in to comment.