Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda store server deps #1069

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Fix conda store server deps #1069

merged 4 commits into from
Feb 4, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jan 30, 2025 •
edited
Loading

Fixes #1068

Description

  • moves flower into dev dependencies (since it is not actually used by the conda-store-server package)
  • add dependencies missing in the conda package recipe
  • add pip check test to conda package recipe

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit deb9cd9
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/679be7b7d1d9bd00086c49bf

@soapy1 soapy1 force-pushed the fix-conda-store-server-deps branch from 4d3ef81 to deb9cd9 Compare January 30, 2025 20:57
@soapy1 soapy1 marked this pull request as ready for review January 30, 2025 21:35
@soapy1 soapy1 requested a review from peytondmurray January 30, 2025 21:41
peytondmurray
peytondmurray approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peytondmurray peytondmurray merged commit a6ce878 into conda-incubator:main Feb 4, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

Assignees
No one assigned
Labels
area: dependencies 📦 Issues related to conda-store dependencies needs: review 👀 type: maintenance 🛠
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conda-store-server conda package dependencies are out of sync with pyproject.toml dependencies
2 participants
@soapy1 @peytondmurray