Document partial signature forgeability #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find, i wasn't aware of this subtlety. Could you please add a link to the source gist so that the curious have a reference? https://gist.github.com/AdamISZ/ca974ed67889cedc738c4a1f65ff620b |
|
@conduition: done! |
|
@AaronFeickert I think rustdoc is complaining about the bare URL reference. Would you mind rectifying that? You can test the doc build locally with Happy holidays 😄 |
AaronFeickert
force-pushed
the
partial-docs
branch
from
ebe2fe9 to
fa192a5
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in a footnote of section 4.2 of the MuSig2 preprint, it is possible for an adversary to forge the partial signature of an honest signer under certain conditions. This means that while validity of all partial signatures from a signing operation necessarily implies validity of the corresponding aggregated signature, validity of any particular partial signature cannot alone be relied on for any use cases requiring its unforgeability.
This is a subtle but important point that was not included in the documentation. This PR updates accordingly.