Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment threads username #45

Closed
wants to merge 19 commits into from
Closed

Comment threads username #45

wants to merge 19 commits into from

Conversation

hn275
Copy link
Collaborator

@hn275 hn275 commented Apr 7, 2023 •
edited
Loading

patch for #42:

  • include username to write and read ops of comments

a lot of diffs are actually from my text editor reformatting code

close #44

mattrltrent and others added 16 commits March 21, 2023 02:57
@mattrltrent
adds template for comment threads
8434744
@mattrltrent
WIP: adds post route for creating threaded comments
dc9d43f
@mattrltrent
WIP: adds deletion handler for comments
58384c7
@mattrltrent
WIP: adds ability to fetch root comments
49d7ace
@mattrltrent
cleans up fetching comments route; general refactoring
a83e473
@mattrltrent
WIP: fetching the comments now returns a flat tree of root comments a…
a49f95f 
…nd part of their threads
@mattrltrent
WIP: fetching comments now returns non-flat tree
3da4480
@mattrltrent
comment trees can now be loaded starting from any comment (not just t…
65e06a3 
…he roots)
@mattrltrent
adds voting on comments
88ff5b3
@mattrltrent
adds ability to sort comments fetched by new, top, worst, controversi…
439878c 
…al, best, and number of replies
@mattrltrent
adds docs for comment deletion route
21767f7
@mattrltrent
adds docs for remaining 3 comment routes and updates post route docs
b01b994
@mattrltrent
adds comments and fixes up some formatting issues
7b5177e
@mattrltrent
removes redundant code in derives
76d9dd5
@hn275
style: consistent indentation
f52282a
@hn275
feat: include username
7e41bfd
@hn275 hn275 requested review from mattrltrent and minitech and removed request for mattrltrent April 7, 2023 22:12
@hn275 hn275 linked an issue Apr 7, 2023 that may be closed by this pull request
Comments should also return a username field to show which user made the comment. #44
Open
@hn275 hn275 requested review from mattrltrent and removed request for minitech April 8, 2023 01:48
mattrltrent
mattrltrent requested changes Apr 8, 2023
View reviewed changes
Copy link
Member

@mattrltrent mattrltrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, comments attached

src/services/comments.rs Outdated Show resolved Hide resolved
src/services/comments.rs Outdated Show resolved Hide resolved
@hn275 hn275 requested a review from mattrltrent April 9, 2023 00:24
@minitech minitech force-pushed the comment_threads branch 2 times, most recently from 179c08a to 13f0053 Compare April 9, 2023 01:30
mattrltrent
mattrltrent approved these changes Apr 9, 2023
View reviewed changes
Copy link
Member

@mattrltrent mattrltrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hn275 hn275 closed this Sep 15, 2023
@hn275
Copy link
Collaborator Author

hn275 commented Sep 15, 2023

closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrltrent mattrltrent mattrltrent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments should also return a username field to show which user made the comment.
2 participants
@hn275 @mattrltrent