Libvirt test create network and storage #1306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am thinking of changing how the storage works. The pool type is a directory pool, so I created a directory in /tmp. While the pool itself is destroyed, the directory is not. |
bookinabox
force-pushed
the
libvirt-test-create-network-and-storage
branch
from
4e9a153
to
f82f30e
Compare
|
I do not know of a way to cleanly delete the directory of a transient storage pool. I'm thinking I can either:
|
bookinabox
force-pushed
the
libvirt-test-create-network-and-storage
branch
from
f82f30e
to
3811ede
Compare
|
Changed it to delete the volumes and just ignore the empty folder in /tmp, but if there are any opinions on if the other ways are better, I would be happy to change it. The reason I don't want to change it to a persistent storage pool is because I'm using its transient status as a way to track whether I should delete it. Otherwise I would need to store some other flag in the libvirt provisioner. Parsing seemed like a slightly more ugly solution to me, but that is not really based on anything. |
bookinabox
changed the title
bookinabox
force-pushed
the
libvirt-test-create-network-and-storage
branch
from
3811ede
to
73829ba
Compare
|
Changed the xml to libvirtxml. |
bookinabox
force-pushed
the
libvirt-test-create-network-and-storage
branch
from
73829ba
to
52ed1c9
Compare
wainersm
reviewed
Aug 14, 2023
| @@ -135,11 +134,99 @@ func (l *LibvirtProvisioner) CreateVPC(ctx context.Context, cfg *envconf.Config) | |||
| ) | |||
|
|
|||
| if _, err := l.conn.LookupNetworkByName(l.network); err != nil { | |||
| return fmt.Errorf("Network '%s' not found. It should be created beforehand", l.network) | |||
| // Check if network is defined, but not enabled | |||
| defined_nets, err := l.conn.ListDefinedNetworks() | |||
There was a problem hiding this comment.
Please use camel-case with Go: s/defined_nets/definedNets/
wainersm
reviewed
Aug 14, 2023
| } | ||
|
|
||
| if sPool, err = l.conn.LookupStoragePoolByName(l.storage); err != nil { | ||
| return fmt.Errorf("Storage pool '%s' not found. It should be created beforehand", l.storage) | ||
|
|
||
| defined_storage, err := l.conn.ListDefinedStoragePools() |
added 2 commits
August 14, 2023 09:13
Creates a temporary network when the specified network is undefined. The resulting network will be transient. Its ip will be automatically chosen. Names corresponding to defined but disabled networks will not be created to avoid unintended side-effects. Temporary networks will be destroyed if TEST_TEARDOWN and TEST_PROVISION are set to "yes". Signed-off-by: Derek Lee <[email protected]>
Creates a directory storage pool in /tmp if the storage name given is not enabled and undefined. Delete volumes on exit from temporary storage. Fixes: confidential-containers#1165 Signed-off-by: Derek Lee <[email protected]>
bookinabox
force-pushed
the
libvirt-test-create-network-and-storage
branch
from
52ed1c9
to
4eeab8f
Compare
|
@bookinabox hi! I'm getting an error: |
We talked a bit in slack, and it looks like it is a kcli version difference. I can either set createCluster to explicitly set the api_ip or we can try to set a kcli version specification? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on: #1244
Creates temporary network and storage if the provided libvirt_network and/or libvirt_storage are not networks/storage pools that are currently enabled.
Destroys network and storage on DeleteVPC (which is triggered when provisioning and teardown are both enabled)