Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade to Elixir 1.16 #134

Merged
merged 2 commits into from
Jan 10, 2024
Merged

⬆️ Upgrade to Elixir 1.16 #134

merged 2 commits into from
Jan 10, 2024

Conversation

randycoulman
Copy link
Collaborator

Describe the purpose of your pull request

Elixir 1.11 is no longer supported, so remove from the CI matrix.

Update Credo to get some 1.16 fixes, which required disabling credo in a few places that now trigger false-positive rule violations. The functions in question are inlined in the config-v6 branch, so this temporary override will go away soon.

Related issues (only if applicable)

Provide links to issues relating to this pull request

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

Elixir 1.11 is no longer supported, so remove from the CI matrix.

Update Credo to get some 1.16 fixes, which required disabling credo in a few places that now trigger false-positive rule violations. The functions in question are inlined in the `config-v6` branch, so this temporary override will go away soon.
@randycoulman randycoulman requested a review from a team as a code owner January 9, 2024 03:40
@randycoulman randycoulman requested a review from kp-cat January 9, 2024 03:40
There were apparently some minor changes in Elixir 1.16's formatter.
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (588a1d7) 94.77% compared to head (4e65f26) 94.28%.
Report is 2 commits behind head on main.

Files Patch % Lines
lib/config_cat/config/setting_type.ex 0.00% 4 Missing ⚠️
lib/config_cat/cache_policy/null.ex 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   94.77%   94.28%   -0.50%     
==========================================
  Files          32       33       +1     
  Lines         766      770       +4     
==========================================
  Hits          726      726              
- Misses         40       44       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randycoulman randycoulman merged commit 7906b96 into main Jan 10, 2024
7 of 9 checks passed
@randycoulman randycoulman deleted the elixir-1.16 branch January 10, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants