Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test #142

Merged
merged 27 commits into from
Nov 4, 2024
Merged

Fix test #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a521d0a
fix test
kp-cat Sep 20, 2024
43493e6
comment out block test
kp-cat Sep 20, 2024
afafa25
remove commented block
kp-cat Sep 20, 2024
8bc5f11
async: false test comment
kp-cat Sep 20, 2024
6d21c8d
comment out block test
kp-cat Sep 20, 2024
e69992c
test trace
kp-cat Sep 20, 2024
da24d76
validate sdk integration test turned off
kp-cat Sep 20, 2024
14fb99d
remove trace from github CI
kp-cat Sep 20, 2024
17f99b3
block test is back
kp-cat Sep 20, 2024
18d442d
- block test + test trace
kp-cat Sep 20, 2024
9430643
print Registry entry
kp-cat Sep 23, 2024
78c48ac
add registry items to warning message
kp-cat Sep 23, 2024
9784b11
message fix
kp-cat Sep 23, 2024
0b7fcd6
test finished log
kp-cat Sep 23, 2024
361bcaf
allow IO.puts
kp-cat Sep 23, 2024
03938e6
print registry
kp-cat Sep 23, 2024
fff2c50
clear registry before all test
kp-cat Sep 23, 2024
67ebd2c
add extra print_registry_contents
kp-cat Sep 24, 2024
f85f685
cleanup
kp-cat Sep 24, 2024
716f9c3
move block test into integration test
kp-cat Sep 24, 2024
20e1260
fix module in integration_test
kp-cat Oct 16, 2024
283b421
revert clear_registry + inline using_block_test
kp-cat Oct 29, 2024
d093a1e
run CI tests with max-cases 1
kp-cat Oct 30, 2024
b7dd1c4
run CI integration tests with max-cases 1
kp-cat Oct 30, 2024
5b76423
CI: merge coverall reports
kp-cat Oct 30, 2024
877ed28
remove max-cases 1
kp-cat Oct 31, 2024
1e1716c
Revert "remove max-cases 1"
kp-cat Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/elixir-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ jobs:
run: mix dialyzer

- name: Execute tests
run: mix coveralls.json --warnings-as-errors
run: |
mix test --only integration --warnings-as-errors --max-cases 1 --cover --export-coverage integration-coverage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--max-cases 1 has no effect here. ExUnit will run async: true modules in parallel with each other, but runs the tests within each module in series. Since there is only one module (aka case) with the integration tag, there will only be one case being run no matter what.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You right but If I remove --max-cases 1, it seems the integration test can be broken again 😒
I'll just keep it like this.

mix coveralls --exclude integration --warnings-as-errors --import-cover cover

- name: Upload coverage report
run: bash <(curl -s https://codecov.io/bash)
Expand Down
5 changes: 4 additions & 1 deletion test/config_cat_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
defmodule ConfigCatTest do
use ConfigCat.ClientCase, async: true
# Must be async: false to avoid a collision with other tests.
# Now that we only allow a single ConfigCat instance to use the same SDK key,
# one of the async tests would fail due to the existing running instance.
use ConfigCat.ClientCase, async: false

import ExUnit.CaptureLog
import Jason.Sigil
Expand Down
2 changes: 2 additions & 0 deletions test/integration_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ defmodule ConfigCat.IntegrationTest do
alias ConfigCat.InMemoryCache
alias ConfigCat.LocalMapDataSource

@moduletag :integration

@sdk_key "configcat-sdk-1/PKDVCLf-Hq-h-kCzMp-L7Q/1cGEJXUwYUGZCBOL-E2sOw"

describe "SDK key validation" do
Expand Down
Loading