Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send etag as query param #91

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Send etag as query param #91

merged 3 commits into from
Dec 27, 2023

Conversation

laliconfigcat
Copy link
Member

Describe the purpose of your pull request

Send etag as a query param, so we can set the If-None-Match header in a CF transform rule if the browser is not sending it.

Related issues (only if applicable)

Provide links to issues relating to this pull request

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@laliconfigcat laliconfigcat requested a review from a team as a code owner December 22, 2023 18:12
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b25860b) 87.50% compared to head (bd3365a) 88.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   87.50%   88.23%   +0.73%     
==========================================
  Files           3        3              
  Lines          48       51       +3     
  Branches        6        7       +1     
==========================================
+ Hits           42       45       +3     
  Misses          4        4              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@laliconfigcat laliconfigcat merged commit 662179e into master Dec 27, 2023
@laliconfigcat laliconfigcat deleted the sendetagasqueryparam branch December 27, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants