Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String List check #60

Merged
merged 3 commits into from
Jan 19, 2024
Merged

String List check #60

merged 3 commits into from
Jan 19, 2024

Conversation

kp-cat
Copy link
Contributor

@kp-cat kp-cat commented Jan 19, 2024

Describe the purpose of your pull request

  • Fix the comment typo in the sample
  • Add string list check
  • Spec char test

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@kp-cat kp-cat requested a review from a team as a code owner January 19, 2024 14:44
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f348cac) 97.01% compared to head (2d767c5) 96.95%.
Report is 1 commits behind head on master.

Files Patch % Lines
configcatclient/rolloutevaluator.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   97.01%   96.95%   -0.06%     
==========================================
  Files          23       23              
  Lines        1572     1578       +6     
==========================================
+ Hits         1525     1530       +5     
- Misses         47       48       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot

See analysis details on SonarCloud

@kp-cat kp-cat requested a review from adams85 January 19, 2024 16:27
@kp-cat kp-cat merged commit 5c6f623 into master Jan 19, 2024
29 of 32 checks passed
@kp-cat kp-cat deleted the sample-update branch January 19, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants