Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix 'delete' environment typo for CP Flink commands #2974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[hotfix] Fix 'delete' environment typo for CP Flink commands #2974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/flink/command_application_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func (c *command) newApplicationCreateCommand() *cobra.Command {
RunE: c.applicationCreate,
}

cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.")
cmd.Flags().String("environment", "", "Name of the environment to create the Flink application from.")
addCmfFlagSet(cmd)
pcmd.AddOutputFlagWithHumanRestricted(cmd)

Expand Down
2 changes: 1 addition & 1 deletion internal/flink/command_application_describe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func (c *command) newApplicationDescribeCommand() *cobra.Command {
RunE: c.applicationDescribe,
}

cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.")
cmd.Flags().String("environment", "", "Name of the environment to describe the Flink application from.")
addCmfFlagSet(cmd)
pcmd.AddOutputFlagWithHumanRestricted(cmd)

Expand Down
2 changes: 1 addition & 1 deletion internal/flink/command_application_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func (c *command) newApplicationListCommand() *cobra.Command {
RunE: c.applicationList,
}

cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.")
cmd.Flags().String("environment", "", "Name of the environment to list the Flink application from.")
addCmfFlagSet(cmd)
pcmd.AddOutputFlag(cmd)

Expand Down
2 changes: 1 addition & 1 deletion internal/flink/command_application_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func (c *command) newApplicationUpdateCommand() *cobra.Command {
RunE: c.applicationUpdate,
}

cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.")
cmd.Flags().String("environment", "", "Name of the environment to update the Flink application from.")
addCmfFlagSet(cmd)
pcmd.AddOutputFlagWithHumanRestricted(cmd)

Expand Down
2 changes: 1 addition & 1 deletion internal/flink/command_application_webui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func (c *command) newApplicationWebUiForwardCommand() *cobra.Command {
RunE: c.applicationWebUiForward,
}

cmd.Flags().String("environment", "", "Name of the environment to delete the Flink application from.")
cmd.Flags().String("environment", "", "Name of the environment to forward the Flink application from.")
addCmfFlagSet(cmd)
cmd.Flags().Uint16("port", 0, "Port to forward the web UI to. If not provided, a random, OS-assigned port will be used.")

Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/create-help-onprem.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application create <resourceFilePath> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to create the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/create-help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application create <resourceFilePath> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to create the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/describe-help-onprem.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application describe <name> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to describe the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/describe-help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application describe <name> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to describe the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/describe-no-environment.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Usage:
confluent flink application describe <name> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to describe the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/forward-negative-port.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Usage:
confluent flink application web-ui-forward <name> [flags]

Flags:
--environment string Name of the environment to delete the Flink application from.
--environment string Name of the environment to forward the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/list-env-missing.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Usage:
confluent flink application list [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to list the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/list-help-onprem.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application list [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to list the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/list-help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application list [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to list the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/update-help-onprem.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application update <resourceFilePath> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to update the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/update-help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application update <resourceFilePath> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to update the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/web-ui-forward-help-onprem.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application web-ui-forward <name> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to forward the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/output/flink/application/web-ui-forward-help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Usage:
confluent flink application web-ui-forward <name> [flags]

Flags:
--environment string REQUIRED: Name of the environment to delete the Flink application from.
--environment string REQUIRED: Name of the environment to forward the Flink application from.
--url string Base URL of the Confluent Manager for Apache Flink (CMF). Environment variable "CONFLUENT_CMF_URL" may be set in place of this flag.
--client-key-path string Path to client private key for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_KEY_PATH" may be set in place of this flag.
--client-cert-path string Path to client cert to be verified by Confluent Manager for Apache Flink. Include for mTLS authentication. Environment variable "CONFLUENT_CMF_CLIENT_CERT_PATH" may be set in place of this flag.
Expand Down