Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI for local users MFA #2979

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

CLI for local users MFA #2979

wants to merge 14 commits into from

Conversation

tmalikconfluent
Copy link
Contributor

@tmalikconfluent tmalikconfluent commented Dec 20, 2024 •
edited
Loading

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • Add Multi-Factor Authentication (MFA) for users logging in using the CLI.

Bug Fixes

  • PLACEHOLDER

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Add Multi-Factor Authentication (MFA) for users logging in using the CLI.

Blast Radius

This will impact all users trying to log into the confluent CLI whose organization has enabled Multi-Factor Authentication (MFA).

References

https://confluentinc.atlassian.net/browse/CLI-3318

Test & Review

Testing Doc: https://docs.google.com/document/d/1woyiPp9a4cPlECj0tfgxl5QRzdkxH-4KDj89MMDQbFM/edit?tab=t.0

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

sgagniere
sgagniere reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments/questions

pkg/auth/auth_token_handler.go Outdated Show resolved Hide resolved
pkg/auth/auth_token_handler.go Outdated Show resolved Hide resolved
pkg/auth/auth_token_handler.go Outdated Show resolved Hide resolved
pkg/auth/mfa/auth_server.go
Comment on lines +14 to +16
//go:embed mfa_callback.html
var mfaCallbackHTML string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this is only used in a print out.

Do we need to keep this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is being used in this file for the output , i think we need this

@tmalikconfluent tmalikconfluent marked this pull request as ready for review January 13, 2025 19:49
@tmalikconfluent tmalikconfluent requested a review from a team as a code owner January 13, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgagniere sgagniere Awaiting requested review from sgagniere

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmalikconfluent @sgagniere