Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link regular expression and test #2982

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

brianstrauch
Copy link
Member

@brianstrauch brianstrauch commented Jan 8, 2025

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • PLACEHOLDER

Bug Fixes

  • Fix broken link highlighting in confluent local kafka start

Checklist

  • I have successfully built and used a custom CLI binary, with no linting issues identified from this PR.
  • I have clearly specified in the Release Notes section above whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR with Confluent Cloud resources in a production environment, if applicable.
  • I have verified this PR with Confluent Platform resources in an on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • Leave this box unchecked if features introduced in this PR are not yet available in production.

What

Before:
Screenshot 2025-01-08 at 11 39 37 AM
After:
Screenshot 2025-01-08 at 11 39 25 AM

References

Test & Review

Unit tests

@brianstrauch brianstrauch requested a review from a team as a code owner January 8, 2025 19:40
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@brianstrauch brianstrauch enabled auto-merge (squash) January 8, 2025 19:41
@brianstrauch brianstrauch disabled auto-merge January 8, 2025 19:41
Copy link
Member

@sgagniere sgagniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants