Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
milindl committed Jan 20, 2025
1 parent d9a9690 commit f99db41
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 16 deletions.
6 changes: 0 additions & 6 deletions .semaphore/post_install.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# This file is managed by ServiceBot plugin - Semaphore. The content in this file is created using a common
# template and configurations in service.yml.
# Any modifications made to version, name, agent, and global_job_config will be overwritten by the generated
# content in nightly runs. Code changes made to the remaining sections will not be affected.
# For more information, please refer to the page:
# https://confluentinc.atlassian.net/wiki/spaces/Foundations/pages/2871296194/Add+SemaphoreCI
version: v1.0
name: post-install
agent:
Expand Down
10 changes: 0 additions & 10 deletions .semaphore/project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,3 @@ spec:
- pull_request
- forked_pull_request
- tag
tasks:
- name: post-install
scheduled: False
branch: "master"
pipeline_file: .semaphore/post_install.yml
parameters:
- name: LIBRARY_VERSION
required: True
description: "Which library version to install."
default_value: "latest"
10 changes: 10 additions & 0 deletions service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ codeowners:
enable: true
semaphore:
enable: true
tasks:
- name: post-install
scheduled: false
branch: "master"
pipeline_file: .semaphore/post_install.yml
parameters:
- name: LIBRARY_VERSION
required: true
description: "Which library version to install."
default_value: "latest"
sonarqube:
enable: true
coverage_reports:
Expand Down

0 comments on commit f99db41

Please sign in to comment.