Add singleton principle to RestService #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claimundefine
commented
Dec 4, 2024
| @@ -51,14 +51,15 @@ export interface ClientConfig { | |||
| const toBase64 = (str: string): string => Buffer.from(str).toString('base64'); | |||
|
|
|||
| export class RestService { | |||
| private static instance: RestService; | |||
| private client: AxiosInstance; | |||
| private baseURLs: string[]; | |||
| private oauthClient?: OAuthClient; | |||
| private oauthBearer: boolean = false; | |||
|
|
|||
| constructor(baseURLs: string[], isForward?: boolean, axiosDefaults?: CreateAxiosDefaults, | |||
There was a problem hiding this comment.
This would normally be private, but this would break the jest mocks and RestService is not exposed to the user regardless.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
bot
force-pushed
the
DGS-19297-create-singleton-for-rest-client
branch
from
b75429d to
2924fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestService would be created multiple times for both the DekRegistry and SchemaRegistry clients. This would specifically be an issue as the OAuth client would also be created twice, with two tokens to manage.