Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANSIENG-4490] Sample inventories for non RBAC to RBAC migration #1893

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

mansisinha
Copy link
Member

@mansisinha mansisinha commented Feb 5, 2025

Description

This PR adds sample inventories to enable rbac in cp-ansible. Sample ACL commands are also added.

Fixes # ANSIENG-4490

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tested locally

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@mansisinha mansisinha requested a review from a team as a code owner February 5, 2025 13:54
## You can skip step 1 if you already have a running cluster
## steps to run:
## 1. setup non rbac (mtls) cluster with "ansible-playbook -i <inv.yml> confluent.platform.all"
## 2. Uncomment Section 1 to enable authorization on cluster and run command "ansible-playbook -i <inv.yml> confluent.platform.all --skip-tags package --tags kafka_controller,kafka_broker -e deployment_strategy=rolling"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we do this step in rolling fashion some broker would have authorizer and some would not. Does that work fine without downtime ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it the case that some brokers which dont have authorizer they allow all actions. the ones which have authorizer they also have allow.everyone.if.no.acl.found: "true" and thus they also allow all actions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, because for inter-broker communication we added broker principal in super user and allow.everyone.if.no.acl.found: "true" for other components

ansible_python_interpreter: /usr/bin/python3

ssl_enabled: true
ssl_mutual_auth_enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deprecated in 7.8 itself. so we can define ssl_client_authentication

@mansisinha mansisinha enabled auto-merge (squash) February 6, 2025 11:28
Copy link
Member

@rrbadiani rrbadiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@mansisinha mansisinha merged commit 9378def into 7.8.x Feb 6, 2025
2 checks passed
@mansisinha mansisinha deleted the rbac-inv-ANSIENG-4490 branch February 6, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants