Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to new docker compose cmd #461

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Cerchie
Copy link

@Cerchie Cerchie commented Dec 10, 2024

Description

Update docker-compose to docker compose. Update docker-compose.yml to canonical compose.yaml.

What behavior does this PR change, and why?

docker-compose is the V1 version of the command and V1 is unsupported and risky. I made the main change and checked for the different commands outlined in the linked guide.

Note: You can create an alias like so:

sudo touch bin/docker-compose
echo 'docker compose --compatibility "$@"' | sudo tee /usr/bin/docker-compose
sudo chmod +x bin/docker-compose                                        

But this is an unsatisfactory experience.

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Note:
This happened both on local branch and 7.8.0-post, could not find anything in the troubleshooting guide to address.

[+] Running 4/4
 ✔ Container openldap   Running                                                                                          0.0s 
 ✔ Container zookeeper  Healthy                                                                                         10.7s 
 ✔ Container kafka2     Started                                                                                          0.4s 
 ✔ Container kafka1     Started                                                                                         10.8s 
Waiting up to 150 seconds for MDS to start
..............................ERROR: Failed after 150 seconds. Please troubleshoot and run again. For troubleshooting instructions see https://docs.confluent.io/platform/current/tutorials/cp-demo/docs/troubleshooting.html

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

  • Run cp-demo
  • documentation needs to update the command as well

@Cerchie Cerchie requested a review from a team as a code owner December 10, 2024 15:54
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant