Changing the Failure to TRY Again in case it fails to update the metadata.
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xvrl
reviewed
Sep 29, 2023
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
Outdated
Show resolved
Hide resolved
xvrl
reviewed
Sep 29, 2023
...kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaIndexTaskTest.java
Outdated
Show resolved
Hide resolved
|
can we add a test case that reproduces this issue and validates that we would handle a situation like that correctly? |
Pankaj260100
changed the title
Failure to TRY Again in case it fails to update the metadata.Failure to TRY Again in case it fails to update the metadata.
Pankaj260100
commented
Oct 5, 2023
...kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaIndexTaskTest.java
Outdated
Show resolved
Hide resolved
xvrl
reviewed
Oct 11, 2023
...ce/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamSequenceNumbers.java
Outdated
Show resolved
Hide resolved
xvrl
reviewed
Oct 11, 2023
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
Outdated
Show resolved
Hide resolved
xvrl
reviewed
Oct 11, 2023
| /** | ||
| * Returns true if the metadata in this instance is greater than the metadata in "other" | ||
| * | ||
| * Behavior is undefined if you pass in an instance of a different class from this one. |
There was a problem hiding this comment.
this should be documented in the interface rather than the implementing class itself, since the caller wouldn't necessarily be aware of it otherwise.
xvrl
reviewed
Oct 11, 2023
...src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamEndSequenceNumbers.java
Outdated
Show resolved
Hide resolved
Pankaj260100
force-pushed
the
pankaj/OBSDATA-2313
branch
from
dcc3d7e to
5a3869a
Compare
Pankaj260100
force-pushed
the
pankaj/OBSDATA-2313
branch
from
9d100ce to
74db290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
Currently, If 2 tasks are consuming from the same partitions, try to publish the segment and update the metadata, the second task can fail because the end offset stored in the metadata store doesn't match with the start offset of the second task. We can fix this by retrying instead of failing.
AFAIK apart from the above issue, the metadata mismatch can happen in 2 scenarios:
In our case, we don't update the topic name very frequently, and 2 replicas of the ingestion task are not deployed in internal metrics prod yet. So, I am planning to test this change in internal metrics prod.
If it works, I will work on a long-term fix. I was able to replicate this issue in internal metrics prod.
Slack link for discussion of the same issue in druid slack: https://apachedruidworkspace.slack.com/archives/C0309C9L90D/p1695710662075909
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
For tips about how to write a good release note, see Release notes.
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: