Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentelemetry-exporter-otlp dependency #61

Open
wants to merge 1 commit into
base: 0.21.0-confluent
Choose a base branch
from

Conversation

IvanVan
Copy link

@IvanVan IvanVan commented Dec 10, 2021

opentelemetry-exporter-otlp was removed in this PR #59, because dependency checker reported error:

[WARNING] Unused declared dependencies found:
[WARNING]    io.opentelemetry:opentelemetry-exporter-otlp:jar:1.7.0:compile

But we need this dependency at runtime, otherwise we get an error.

Caused by: org.apache.druid.opentelemetry.shaded.io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException: OTLP gRPC Trace Exporter enabled but opentelemetry-exporter-otlp not found on classpath. Make sure to add it as a dependency to enable this feature.

@@ -161,6 +165,7 @@
<configuration>
<ignoredUnusedDeclaredDependencies>
<!-- Transitive dependencies from opentelemetry but explicitly added to be shadowed -->
<ignoredUnusedDeclaredDependency>io.opentelemetry:opentelemetry-exporter-otlp</ignoredUnusedDeclaredDependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of ignoring it, it might be enough to make opentelemetry-exporter-otlp a runtime scope dependency to make it clear it's not used at compile time but required at runtime.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sounds good
I tried to push a commit to this PR, but I don't have permissions
Permission to confluentinc/druid.git denied to IvanVan.

Also I don't know how to update PR upstream, because there is the same issue there and I want to add info about tracestate
I can create another PR to upstream from my own fork
What do you think of it? @xvrl

@cla-assistant
Copy link

cla-assistant bot commented Aug 11, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants