-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: remove ZK from code base #529
Open
mjsax
wants to merge
10
commits into
master
Choose a base branch
from
remove-zk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cc3d33a
MINOR: remove ZK from code base
mjsax f2b14bf
bump Java to 17
mjsax 659002f
Update JDK to 17
mjsax 44931e3
fix tests
mjsax 24ad13e
Remove algebird example
mjsax 364222d
update readme
mjsax 2ae2bea
update
mjsax 8f62ae1
readme
mjsax 83772a7
remvove log
mjsax e43359c
pom update
mjsax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,7 @@ | |
<chill.version>0.9.5</chill.version> | ||
<docker.skip-build>false</docker.skip-build> | ||
<docker.skip-test>false</docker.skip-test> | ||
<java.version>11</java.version> | ||
<java.version>17</java.version> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
<scalatest.version>3.1.2</scalatest.version> | ||
<!-- The default is ubi8 --> | ||
|
@@ -124,14 +124,6 @@ | |
<!-- This version must be compatible with the Scala version of the Kafka dependency. --> | ||
<version>${scala.version}</version> | ||
</dependency> | ||
<dependency> | ||
<!-- This could be a test-only dependency, but we keep it a compile dependency so that | ||
users are able to package the examples via `mvn package` and actually run the examples | ||
against a Kafka cluster. --> | ||
<groupId>com.101tec</groupId> | ||
<artifactId>zkclient</artifactId> | ||
<version>0.9</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.slf4j</groupId> | ||
<artifactId>slf4j-reload4j</artifactId> | ||
|
@@ -181,6 +173,11 @@ | |
<artifactId>jackson-databind</artifactId> | ||
<version>${jackson.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>jakarta.xml.bind</groupId> | ||
<artifactId>jakarta.xml.bind-api</artifactId> | ||
<version>4.0.1</version> | ||
</dependency> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. W/o this, I got some |
||
<!-- | ||
This dependency is included to demonstrate the use of | ||
Confluent Monitoring Interceptors in conjunction with | ||
|
@@ -241,6 +238,12 @@ | |
<classifier>test</classifier> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.apache.kafka</groupId> | ||
<artifactId>kafka-test-common-runtime</artifactId> | ||
<version>${kafka.version}</version> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.apache.kafka</groupId> | ||
<artifactId>kafka-streams-test-utils</artifactId> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change from 11 to 8? 11 is the recommended version for CP.
should we cover 6.x releases as well in case of (out of support window) backports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 7.x, we still support Java 8. -- I don't think it's about recommended, but supported?
It's more a question for @hk10111 thouhg. Cf #527
I would have hard-coded Java 8 for older branches and hard-coded Java 17 for 8.0+, but they want to have the same
semaphore.yml
config across all branches -- that's why the if-else.Guess we could also use Java 11 for older branches, but historically we use Java 8.
Anyway, the other commit finally made it into all branches I believe, so this change will go away for this PR anyway.