Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port placement when path based routing is used #10642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

boriscosic
Copy link

Description

As per #10641, when path routing is used without port, port is appended to serverAddress resulting in incorrect endpoint.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@boriscosic boriscosic requested a review from a team as a code owner January 13, 2025 21:48
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ boriscosic
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@hrishabhg
Copy link
Member

@boriscosic looks good to me. thanks.

@pbadani pbadani changed the base branch from master to 7.1.x January 15, 2025 10:22
@pbadani pbadani requested a review from JimGalasyn as a code owner January 15, 2025 10:22
@pbadani pbadani changed the base branch from 7.1.x to master January 15, 2025 10:23
@pbadani
Copy link
Member

pbadani commented Jan 15, 2025

@boriscosic Can you create this PR against 7.1.x branch?

@boriscosic
Copy link
Author

boriscosic commented Jan 16, 2025

@pbadani just saw this and created a PR against 7.1.x #10650. Please feel free to close if not needed @hrishabhg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants