Update plugin to be compliant with Leaflet 1.9.4 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This support is to be up to date with Leaflet current behavior.
This {r} variable is used to be compatible with retina screens.
More information : https://github.com/Leaflet/Leaflet/pull/2296/files
- Test successfully with Leaflet 1.9.4 - Change layers to use working url - Update documentation in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 commits :
1 - [ADD] Support for {r} format in urls
This improvement is to be up to date with Leaflet current behavior.
This {r} variable is used to be compatible with retina screens in some URLs and therefore need to be taken in consideration by this plugin.
More information : https://github.com/Leaflet/Leaflet/pull/2296/files
2 - [Improve] Examples file and documentation with working examples
While doing this fix I tested the plugin with last version of leaflet and it seems to be working fine. I decided to update exemples accordingly and fix the URL currently used that are not working anymore.
I also added URLs compliant with the {r} parameter to display and test my previous commit.
Contains :
3 - [DOC] Add new contributor
Because I was editing the readme and I saw this section I added myself as contributor. You can obviously remove this commit if you want, I don't care.