Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imk support mnemonic verification feature[R2D2-11881] #119

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

xiaoguang1010
Copy link
Contributor

Summary of Changes

imk support mnemonic verification feature

https://imtoken.atlassian.net/browse/R2D2-11881

Motivation and Context

How Has This Been Tested? (Test Plan)

Other information

Screenshots (if appropriate):

Final checklist

  • Did you test both iOS and Android(if applicable)?
  • Is a security review needed(consenlabs/security)?

Security checklist (only for leader check)

  • No backdoor risk
    • Check for unknown network request urls, and script/shell files with unclear purposes,
    • The backend service cannot expose leaked data interfaces for various reasons (even for testing purposes)
  • No network communication protocol risk
    • Check whether to introduce unsafe network calls such as http/ws
  • No import potentially risk 3rd library
    • Check whether 3rd dependent library is import
    • Don't use an unknown third-party library
    • Check the 3rd library sources are fetched from normal sources, such as npm, gomodule, maven, cocoapod, Do not use unknown sources
    • Check github Dependabot alerts, Whether to add new issues
  • Private data not exposed
    • Check whether there are exclusive ApiKey, privatekey and other private information uploaded to git
    • Check if the packaged keystore has been uploaded to git

@@ -40,6 +40,8 @@ pub enum ApduError {
ImkeyInMenuPage,
#[error("imkey_pin_not_verified")]
ImkeyPinNotVerified,
#[error("imkey_mnemonic_check_fail")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: 其实这里最好是 Check Failed

@xiaoguang1010 xiaoguang1010 merged commit ade18a2 into dev Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants